From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Nikhil S <nixmisc(at)gmail(dot)com> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: pgAdmin III: the debugger does not pre-populate default values for arguments |
Date: | 2011-02-08 06:35:33 |
Message-ID: | 4D50E435.2060600@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Le 07/02/2011 09:03, Nikhil S a écrit :
> [...]
> The debugger, when it is invoked on a function or a procedure, provides a
> dialogue box to fill up values for the arguments. In case the user has
> created them with some default values assigned to some of the parameters,
> then they would expect that the debugger pre-populates them with those
> default values. This is not happening currently.
>
> The attached patch provides this functionality.
>
> We check if the "argdefvals" column exists in the output for the func/proc.
> If it does, it gets tokenized and added to the corresponding wsArgInfo
> object. These values then get displayed appropriately.
>
> One side-effect of this feature is that earlier where non-default variables
> appeared as empty, they will now appear with values "". This will happen
> only if some arguments have defvals and some don't. We could have added code
> to do away with "" entries, but then I thought it is possible for people to
> provide "" as default values too. So we can live with this I think..
>
Seems a great idea to me.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2011-02-08 06:48:35 | Re: Feature: visual feedback of disabled triggers |
Previous Message | Guillaume Lelarge | 2011-02-08 06:34:32 | Re: pgAdmin III: error while browsing schema of PG database |