| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Andy Colson <andy(at)squeakycode(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: texteq/byteaeq: avoid detoast [REVIEW] |
| Date: | 2011-01-18 08:06:24 |
| Message-ID: | AANLkTimDY5tiwoSMGVGmAr18CXzF5q__b6rnhZYuTTcb@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 18, 2011 at 05:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I haven't looked at this patch, but it seems to me that it would be
> reasonable to conclude A != B if the va_extsize values in the toast
> pointers don't agree.
It's a very light-weight alternative of memcmp the byte data,
but there is still the same issue -- we might have different
compressed results if we use different algorithm for TOASTing.
So, it would be better to apply the present patch as-is.
We can improve the comparison logic over the patch in another
development cycle if possible.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Kirkwood | 2011-01-18 08:14:41 | Re: pg_filedump moved to pgfoundry |
| Previous Message | Heikki Linnakangas | 2011-01-18 08:03:01 | Re: texteq/byteaeq: avoid detoast [REVIEW] |