| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [v9.1] add makeRangeTblEntry() into makefuncs.c |
| Date: | 2010-06-14 12:06:04 |
| Message-ID: | AANLkTilhupDvsggEsbzYqSJoXmGlD2S6S1vpvNXM0jwi@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2010/6/14 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
> The attached patch was a part of DML refactoring and security hook patches.
>
> It adds makeRangeTblEntry() into makefuncs.c to keep the code more
> clean. It shall be also used for the upcoming DML refactor patch.
> In this refactoring, a common DML permission checker function take
> a list of RangeTblEntry, so the caller has to set up the object.
I think this is the epitome of pointless. It looks to me like this
just makes the code harder to read and very slightly slower without
actually accomplishing any useful abstraction.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-06-14 12:08:06 | Re: Typo in plperl doc ? |
| Previous Message | Simon Riggs | 2010-06-14 11:55:59 | Re: Proposal for 9.1: WAL streaming from WAL buffers |