From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and |
Date: | 2010-07-08 16:42:18 |
Message-ID: | AANLkTil7xQUpkr0MpAYXRqUbjGaV6_WrBLDEeOIR_dhr@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Jul 8, 2010 at 18:37, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Here's what I came up with and will apply as soon as my msvc build
>> completes. (the mingw one works with this)
>
> This is still going to need manual adjustment in the future, since
> probably when mingw adds the #define, they will put it in <mstcpip.h>,
> and this code will not see it. So at some point we'll need to add an
> autoconf test for <mstcpip.h> and replace those #ifdef
> WIN32_ONLY_COMPILER checks with #ifdef HAVE_MSTCPIP_H. But I see no
> need to bother until such a version of mingw exists, and I'd just as
> soon not be making such changes on the day of a wrap. So this is just
> a note for later.
Agreed.
And it's far from certain they'll actually add it to mstcpip.h -
sometimes they stick it in a different header...
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2010-07-08 16:44:12 | pgsql: Doc change: effected -> affected, per correction from Matthew |
Previous Message | Andrew Dunstan | 2010-07-08 16:40:02 | Re: pgsql: Make the Windows tcp keepalive support depend on the existance of |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2010-07-08 16:44:37 | Re: Reviewfest 2010-06 Plans and Call for Reviewers |
Previous Message | Tom Lane | 2010-07-08 16:37:43 | Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and |