| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and |
| Date: | 2010-07-08 16:37:43 |
| Message-ID: | 27190.1278607063@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Here's what I came up with and will apply as soon as my msvc build
> completes. (the mingw one works with this)
This is still going to need manual adjustment in the future, since
probably when mingw adds the #define, they will put it in <mstcpip.h>,
and this code will not see it. So at some point we'll need to add an
autoconf test for <mstcpip.h> and replace those #ifdef
WIN32_ONLY_COMPILER checks with #ifdef HAVE_MSTCPIP_H. But I see no
need to bother until such a version of mingw exists, and I'd just as
soon not be making such changes on the day of a wrap. So this is just
a note for later.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2010-07-08 16:40:02 | Re: pgsql: Make the Windows tcp keepalive support depend on the existance of |
| Previous Message | Tom Lane | 2010-07-08 16:30:13 | pgsql: Add a cross-reference to precedence information to CREATE |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2010-07-08 16:42:18 | Re: [HACKERS] pgsql: Add support for TCP keepalives on Windows, both for backend and |
| Previous Message | Robert Haas | 2010-07-08 16:29:47 | Re: Reviewfest 2010-06 Plans and Call for Reviewers |