Some git conversion issues

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Some git conversion issues
Date: 2010-07-20 13:12:40
Message-ID: AANLkTil4btrt-gJK0S0vxZAFbNtT3baap-hW4Sv8VAEN@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Working on the git conversion with keywords, and I've noticed a couple of
strange things that don't come up the same way in git. All of these are in
non-code files, but they do defeat the "identical tarball" mode.

For example, a number of files have commits showing up in cvs with nothing at
all changed. This triggered an update of the keywords only, with no contents
changed.

For example, look at:
http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/Attic/FAQ_AIX.diff?r1=1.19.2.9;r2=1.19.2.10
http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/Attic/FAQ_HPUX.diff?r1=1.14.2.9;r2=1.14.2.10
http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/Attic/FAQ_Solaris.diff?r1=1.22.2.10;r2=1.22.2.11

Some show up as completely empty, like:
http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/generate_history.pl.diff?r1=1.1;r2=1.1.2.1

Does anybody know how this can even happen? Wouldn't cvs normally just
not commit the file if there are no changes?

I'm also seeing some entries tagged with "vendor branch", such as:
http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/smgr/README
revision 1.1.1.1

Same issue there, the file comes out on the other end with the wrong keyword (in
this case, listed as 1.1).

I admit I don't even know what a vendor branch is, except I know I've
been annoyed by them before :-)

Other than keywords, the contents of every branch and every tag are correct. I
haven't checked any arbitrary revisions (that's really hard to do with cvs..),
but I have a script that checks every branch and every tag present in
configure, configure.in and README (in the root dir), which should hopefully
cover everything. Does anybody know a better way to find out all tags and
branches that exist, or some other file I should also be looking at?

The full list of files having keyword issues due to these two things (AFAICT so
far, these are the only issues) are:
doc/FAQ_AIX
doc/src/sgml/generate_history.pl
doc/src/sgml/release-old.sgml
src/backend/catalog/README
src/backend/nodes/README
src/backend/po/es.po
src/backend/storage/ipc/README
src/backend/storage/smgr/README
src/bin/initdb/po/de.po
src/bin/initdb/po/fr.po
src/bin/pg_config/po/de.po
src/bin/pg_config/po/fr.po
src/bin/pg_controldata/po/de.po
src/bin/pg_controldata/po/es.po
src/bin/pg_controldata/po/fr.po
src/bin/pg_ctl/po/de.po
src/bin/pg_dump/po/de.po
src/bin/pg_dump/po/fr.po
src/bin/pg_dump/po/sv.po
src/bin/pg_resetxlog/po/de.po
src/bin/psql/po/de.po
src/bin/psql/po/es.po
src/bin/psql/po/fr.po
src/bin/psql/po/sv.po
src/bin/scripts/po/de.po
src/bin/scripts/po/fr.po
src/interfaces/libpq/po/de.po
src/interfaces/libpq/po/fr.po
src/interfaces/libpq/po/sv.po

Any thoughts or ideas on how to fix these? Or shuld we accept and ignore
those differences?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2010-07-20 13:23:39 Re: Explicit psqlrc
Previous Message Robert Haas 2010-07-20 13:05:55 Re: Explicit psqlrc