Re: why two dashes in extension load files

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: why two dashes in extension load files
Date: 2011-02-14 16:58:12
Message-ID: AANLkTikx4LL9sPCVNnRUSbQkdsPVHuTcbaQuvw2DjHb_@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 14, 2011 at 6:49 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> > Why do the extension load files need two dashes, like xml2--1.0.sql?
>> > Why isn't one enough?
>>
>> Because we'd have to forbid dashes in extension name and version
>> strings.  This was judged to be a less annoying solution.  See
>> yesterday's discussion.
>
> I'm not convinced.  There was nothing in that discussion why any
> particular character would have to be allowed in a version number.  I'd
> propose that dashes should be prohibited in version names anyway,
> because downstream packaging will want to use that to separate packaging
> revisions.  It might be better to discuss that explicitly rather than
> hiding it in some thread of another title.

I think the question is more - what do we disallow in package name?

Eg. Debian disallows '_' and uses it as magic separator. It works,
but it not as obvious as '-' vs '--', and '--' allows both '_' and '-' in
package name. Unlikely anyone will want '--' in package name.

I would vote for current '--' and keeping version name simple,
no '_' and '-' there. As we want to do some logic on that.

--
marko

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2011-02-14 17:06:39 Re: Extensions vs PGXS' MODULE_PATHNAME handling
Previous Message Tom Lane 2011-02-14 16:54:38 Re: why two dashes in extension load files