Re: why two dashes in extension load files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: why two dashes in extension load files
Date: 2011-02-14 16:54:38
Message-ID: 25984.1297702478@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On mn, 2011-02-14 at 10:13 -0500, Tom Lane wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> Why do the extension load files need two dashes, like xml2--1.0.sql?
>>> Why isn't one enough?

>> Because we'd have to forbid dashes in extension name and version
>> strings. This was judged to be a less annoying solution. See
>> yesterday's discussion.

> I'm not convinced. There was nothing in that discussion why any
> particular character would have to be allowed in a version number.

Well, there's already a counterexample in the current contrib stuff:
uuid-ossp. We could rename that to uuid_ossp of course, but it's
not clear to me that there's consensus for forbidding dashes here.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marko Kreen 2011-02-14 16:58:12 Re: why two dashes in extension load files
Previous Message Tom Lane 2011-02-14 16:52:14 Re: Extensions vs PGXS' MODULE_PATHNAME handling