| From: | Joachim Wieland <joe(at)mcknight(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Snapshot synchronization, again... |
| Date: | 2011-02-19 00:41:51 |
| Message-ID: | AANLkTik0SFP8CJCxSeH9nzKw9a-+da93bHW8spB2joTF@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 18, 2011 at 8:57 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> 1. why are you using the expansible char array stuff instead of using
> the StringInfo facility?
>
> 2. is md5 the most appropriate digest for this? If you need a
> cryptographically secure hash, do we need something stronger? If not,
> why not just use hash_any?
We don't need a cryptographically secure hash.
There is no special reason for why it is like it is, I just didn't
think of the better alternatives that you are proposing.
Should I send an updated patch? Anything else?
Thanks for the review,
Joachim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-02-19 00:42:15 | Re: Re: [COMMITTERS] pgsql: Make a hard state change from catchup to streaming mode. |
| Previous Message | Thom Brown | 2011-02-19 00:32:17 | Re: Sync Rep v17 |