Re: MingW and MiniDumps

On Sun, Dec 26, 2010 at 01:10, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 12/20/2010 01:25 PM, Magnus Hagander wrote:
>>
>> On Mon, Dec 20, 2010 at 19:24, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us>  wrote:
>>>
>>> Andrew Dunstan<andrew(at)dunslane(dot)net>  writes:
>>>>
>>>> Maybe. I have no idea where narwhal got its version of dbghelp.h. I
>>>> copied the file from the SDK directory to mingw's include directory and
>>>> the build then ran perfectly. I think therefore the right thing is to
>>>> have a configure test for the file and for MINIDUMP_TYPE on win32, and
>>>> only build in crashdump if it passes those tests.
>>
>> +1.
>>
>>
>
> Suggested patch attached.

I wonder if we need to actually care about which enum values are
actually within the symbol. But let's try it this way first and see
what the buildfarm has to say about that.

Doesn't this break the msvc build? (Sorry, don't have one up to test
right now).. You moved the crashdump.o file to a separate line from
OBS, which I believe will make the msvc build system loose it. So
you'll have to explicitly add it back on msvc, in Mkvcbuild.pm.

Other than that, looks good.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/