Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.

From: Jan Urbański <wulczer(at)wulczer(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>
Subject: Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.
Date: 2010-12-26 13:03:27
Message-ID: 4D173D1F.2060408@wulczer.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 26/12/10 05:55, Robert Haas wrote:
> On Sat, Dec 25, 2010 at 3:39 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>>> Add foreign data wrapper error code values for SQL/MED.
>>> Extracted from a much larger patch by Shigeru Hanada.
>>
>> This patch is quite incomplete. Any patch that adds to errcodes.h
>> *must* also touch
>> doc/src/sgml/errcodes.sgml
>> src/pl/plpgsql/src/plerrcodes.h
>
> Drat. OK, will work on it tomorrow. I didn't realize those places
> needed to be updated.

I noticed the other day that plerrcodes.h has a comment saying is should
be generated with some sed hackery, and as I needed to generate a Python
exception class for each error in errcodes.h I did the hackery.

See
https://github.com/wulczer/postgres/commit/44fc42b7708f23483156e4e0e1e321e68b2a7e2d#diff-0
for something that maybe could be used as a basis to autogenerate
errcodes.sgml and plerrcodes.h.

Cheers,
Jan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-12-26 14:29:19 Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.
Previous Message Robert Haas 2010-12-26 04:55:06 Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-12-26 14:29:19 Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.
Previous Message Magnus Hagander 2010-12-26 09:35:32 Re: MingW and MiniDumps