Re: RecordTransactionCommit() and SharedInvalidationMessages

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: RecordTransactionCommit() and SharedInvalidationMessages
Date: 2010-08-13 16:01:24
Message-ID: AANLkTi=K33CCn-RG67np6b2BSdaSb_CCinfx6tkDPjzV@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 12, 2010 at 9:43 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Fri, Aug 13, 2010 at 10:24 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Thu, Aug 12, 2010 at 12:11 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>>>>> It appears to me that RecordTransactionCommit() only needs to WAL-log
>>>>>>> shared invalidation messages when wal_level is hot_standby, but I
>>>>>>> don't see a guard to prevent it from doing it in all cases.
>>>> Should use XLogStandbyInfoActive() macro, for the sake of consistency.
>>> And, RelcacheInitFileInval should be initialized with false just in case.
>>
>> How about this?
>
> Looks good to me.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-08-13 16:11:04 Re: patch: utf8_to_unicode (trivial)
Previous Message Robert Haas 2010-08-13 16:00:32 Re: patch: utf8_to_unicode (trivial)