Re: patch: utf8_to_unicode (trivial)

Excerpts from Robert Haas's message of vie ago 13 12:00:32 -0400 2010:
> On Fri, Aug 13, 2010 at 3:12 AM, Joseph Adams
> <joeyadams3(dot)14159(at)gmail(dot)com> wrote:
> > I've attached another patch that moves utf8_to_unicode to src/port per
> > Robert Haas's suggestion.
> >
> > This patch itself is not quite as elegant as the first one because it
> > puts platform-independent code that "belongs" in wchar.c into src/port
> > .  It also uses unsigned int instead of pg_wchar because the typedef
> > of pg_wchar isn't available to the frontend, if I'm not mistaken.
>
> Well, right now, in addition to having two copies of utf2ucs(), we
> have two declarations of pg_wchar, one in src/bin/psql/mbprint.c and
> the other in src/include/mb/pg_wchar.h; so both existing copies of the
> function are able to use that typedef. It seems like we might want to
> move the typedef to the same place as the declaration of the renamed
> utf2ucs(), but I'm not quite sure where that should be. The only
> header in src/port is pthread-win32.h, and we're sure not going to put
> it there.

src/include/port.h?

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support