Re: Replication logging

On Tue, Jan 18, 2011 at 08:21, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Jan 18, 2011 at 4:15 PM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>> I also find it weird that incoming replication connections are logged by
>> default. In the standby, we also log "streaming replication successfully
>> connected to primary", which serves much of the same debugging purpose. That
>> standby-side message is ok, we have a tradition of being more verbose during
>> recovery, we also emit the "restored log file \"%s\" from archive" message
>> for every WAL segment restored from archive for example.
>>
>> We could turn log_connections into an enum, like log_statement:
>>
>> log_connections = 'none'        # none, replication, regular, all

It almost seems overkill, but probably less so than a completely new guc :)

> We should treat log_disconnections the same?

We could keep it a boolean, but then only log disconnections for the
cases that are mentioned in log_connections?

It doesn't make sense to log disconnection for a connection we didn't
log the connection for...

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/