From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers |
Date: | 2011-01-05 05:05:10 |
Message-ID: | AANLkTi==qXqF8geR=_vC7AXyWrghckkUAhKOfjD=51Tu@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus(at)hagander(dot)net>wrote:
> On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>wrote:
>
>> Hi Magnus/Dave,
>>
>> This check-in has added one compilation error.
>> The following line introduce an error in file '*pgadmin/db/keywords.c*'
>> *#include <server/parser/gram.h>
>> #include <server/parser/kwlist.h>*
>>
>> Because - these header files does not always find under *`pg_config
>> --includedir`* folder, but can be found under *`pg_config
>> --pkgincludedir`*.
>>
>> Please find the patch to resolve the issue. This applies on both master
>> and REL-1_12_PATCHES branch.
>>
>>
> Looks good in general, but do we actually need to put it on 1.12? The
> keyword build changes were only applied to master, so unless we actually
> *need* it on the back branch, I don't think we should put it there. Is it
> needed for something else as well?
>
You're right.
This patch should only be applied on master.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>
>
> --
> Magnus Hagander
> Me: http://www.hagander.net/
> Work: http://www.redpill-linpro.com/
>
From | Date | Subject | |
---|---|---|---|
Next Message | Jasmin Dizdarevic | 2011-01-05 11:09:08 | Debug works, Release not |
Previous Message | Russell L. Galyon | 2011-01-04 22:37:28 | pgAdmin Crashes When Opening a *.sql File From Windows Explorer |