Re: Add SKIP LOCKED to VACUUM and ANALYZE

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Andres Freund" <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com>
Subject: Re: Add SKIP LOCKED to VACUUM and ANALYZE
Date: 2018-10-02 02:22:42
Message-ID: A9A46611-2AD6-4FF2-AB17-DD5AC774BD1B@amazon.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 10/1/18, 7:07 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> On Mon, Oct 01, 2018 at 03:37:01PM +0000, Bossart, Nathan wrote:
>> Without the find_all_inheritors() stuff, I think we would just need to
>> modify the ANALYZE documentation patch to say something like
>>
>> Specifies that ANALYZE should not wait for any conflicting locks
>> to be released: if a relation cannot be locked immediately without
>> waiting, the relation is skipped. Note that even with this
>> option, ANALYZE can still block when opening the relation's
>> indexes or when acquiring sample rows to prepare the statistics.
>> Also, while ANALYZE ordinarily processes all leaf partitions of
>> partitioned tables, this option will cause ANALYZE to skip all
>> leaf partitions if there is a conflicting lock on the partitioned
>> table.
>
> Yes, I think that we could live with something like that. I could give
> this whole thing a shot, but this will have to wait until the commit
> fest is closed as there are still many patches to classify. If you can
> send a patch that's of course always helpful..

Sure, here it is.

Nathan

Attachment Content-Type Size
vacuum-skip-locked-v10.patch application/octet-stream 14.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-10-02 02:22:52 Re: WIP Patch: Precalculate stable functions, infrastructure v1
Previous Message Tom Lane 2018-10-02 02:21:58 Re: TupleTableSlot abstraction