Re: Add SKIP LOCKED to VACUUM and ANALYZE

On 10/1/18, 7:07 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> On Mon, Oct 01, 2018 at 03:37:01PM +0000, Bossart, Nathan wrote:
>> Without the find_all_inheritors() stuff, I think we would just need to
>> modify the ANALYZE documentation patch to say something like
>>
>> Specifies that ANALYZE should not wait for any conflicting locks
>> to be released: if a relation cannot be locked immediately without
>> waiting, the relation is skipped. Note that even with this
>> option, ANALYZE can still block when opening the relation's
>> indexes or when acquiring sample rows to prepare the statistics.
>> Also, while ANALYZE ordinarily processes all leaf partitions of
>> partitioned tables, this option will cause ANALYZE to skip all
>> leaf partitions if there is a conflicting lock on the partitioned
>> table.
>
> Yes, I think that we could live with something like that. I could give
> this whole thing a shot, but this will have to wait until the commit
> fest is closed as there are still many patches to classify. If you can
> send a patch that's of course always helpful..

Sure, here it is.

Nathan