| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [doc] modifying unit from characters to bytes |
| Date: | 2020-07-08 07:17:45 |
| Message-ID: | A96F46F3-65BB-4E1E-A423-8EE29729547F@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 8 Jul 2020, at 04:25, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> On 2020/07/08 10:54, torikoshia wrote:
>> Hi,
>> The manual describes the size of pg_stat_activity.query
>> as below:
>> | By default the query text is truncated at 1024 characters;
>> When considering multibyte characters, it seems more
>> accurate to change the unit from "characters" to "bytes".
>
> Agreed. Barring any objection, I will commit this patch.
+1 to commit this patch, following the link to track_activity_query_size it's
even specified to be bytes there. IIRC the NULL terminator is also included in
the 1024 bytes which prevents it from being 1024 characters even for
non-multibyte.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-07-08 07:41:31 | Re: Is it useful to record whether plans are generic or custom? |
| Previous Message | Amit Kapila | 2020-07-08 07:04:44 | Re: Resetting spilled txn statistics in pg_stat_replication |