From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [doc] modifying unit from characters to bytes |
Date: | 2020-07-08 08:05:47 |
Message-ID: | 88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020/07/08 16:17, Daniel Gustafsson wrote:
>> On 8 Jul 2020, at 04:25, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>
>> On 2020/07/08 10:54, torikoshia wrote:
>>> Hi,
>>> The manual describes the size of pg_stat_activity.query
>>> as below:
>>> | By default the query text is truncated at 1024 characters;
>>> When considering multibyte characters, it seems more
>>> accurate to change the unit from "characters" to "bytes".
>>
>> Agreed. Barring any objection, I will commit this patch.
>
> +1 to commit this patch, following the link to track_activity_query_size it's
> even specified to be bytes there. IIRC the NULL terminator is also included in
> the 1024 bytes which prevents it from being 1024 characters even for
> non-multibyte.
Yes, so we should document "truncated at 1023 bytes" for accuracy, instead?
This might be more confusing for users, though....
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2020-07-08 08:12:18 | Re: [doc] modifying unit from characters to bytes |
Previous Message | Daniel Gustafsson | 2020-07-08 08:04:55 | Typo in pgstat.c |