| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, schefner20(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster |
| Date: | 2026-11-19 20:49:44 |
| Message-ID: | A6C4AA49-61F6-4E35-9A5E-D03351111CEC@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 19 Nov 2026, at 18:55, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I'm generally in favor of adding a note,
Thanks for looking!
> but I wouldn't put it here or
> say this. One thing I think we should do is change the doc string for
> --check, which currently says "check clusters only, don't change any
> data," but could just as well say "check clusters, but don't perform
> the upgrade". But at the point where you added this, I'd suggest
> writing something more like this: Note that, even when --check is
> used, pg_upgrade will start and stop the old cluster, unless it is
> already running. It is, therefore, not a strictly read-only operation,
> and must only be performed in a context where the old server is
> accessible, and from which starting and stopping it is safe.
Nice, that's much better than what I came up with. Changed as per the above
with minor tweaks and markup. I did leave he <note> where I had originally
placed it since I'm not sure if you're advocating for moving it or leaving it
in place?
Further down under section 17. "Reverting to old cluster", we repeatedly state
that the old cluster was unmodified, which is promising a bit too much (though
I understand the intent). For example:
"If the --check option was used, the old cluster was unmodified; it can
be restarted."
I've been trying to come up with a wording which implies that no user data was
modified, and the cluster can be restarted, but english is clearly not on the
list of skills I possess tonight and I've failed. Do you have any suggestions?
My best attempt below doesn't really feel like the improvement I was going for.
"If the --check option was used, no changes have been made to the old
cluster which prevents it from being restarted and reverted to."
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-doc-Document-that-pg_upgrade-check-isn-t-read-onl.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-11-19 21:47:12 | Re: BUG #19922: CYCLE/SEARCH with a window in the recursive term: could not find replacement targetlist entry |
| Previous Message | Tom Lane | 2026-11-19 20:21:19 | Re: BUG #19916: UNION over hash-only and sort-only columns: could not devise a query plan |