| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, schefner20(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster |
| Date: | 2026-11-19 17:55:10 |
| Message-ID: | CA+TgmoYR9aQnCaSX0UKG219BBPOMcTFXZq1_wLedvJSs2uLhrQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Nov 19, 2026 at 7:38 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> I wasn't able to come up with a good idea either, but I propose that we at
> least add a note to the documentation. How about something like the attached
> to at least make it visible until we have a solution?
I'm generally in favor of adding a note, but I wouldn't put it here or
say this. One thing I think we should do is change the doc string for
--check, which currently says "check clusters only, don't change any
data," but could just as well say "check clusters, but don't perform
the upgrade". But at the point where you added this, I'd suggest
writing something more like this: Note that, even when --check is
used, pg_upgrade will start and stop the old cluster, unless it is
already running. It is, therefore, not a strictly read-only operation,
and must only be performed in a context where the old server is
accessible, and from which starting and stopping it is safe.
I'd rather not make this specifically about containers.
--
Robert Haas
Databricks
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Andrey Rachitskiy | 2026-11-19 17:32:32 | Re: BUG #19921: auto_explain Reads SQL Function Parameters from an Unpinned Buffer |