Re: Add explicit warnings about unsafe OAuth trace output for libpq

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Subject: Re: Add explicit warnings about unsafe OAuth trace output for libpq
Date: 2026-08-24 09:32:25
Message-ID: A109C9D5-ADD5-4621-B3A2-E1360DEB3AA9@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 19 Aug 2026, at 14:06, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:

>>> The documentation already mentions that this option is unsafe because
>>> it prints out the HTTP traffic as-is, including secrets, but the
>>> output itself lacks a warning about it.
>>>
>>> Because the output is long, users might not notice that copy-pasting
>>> it or saving it to disk will share sensitive information. To increase
>>> visibility, this patch adds a warning to both the beginning and the
>>> end of the output.

I think it's a good idea to include a warning in the output like this. Ideally
it's just repeating what the user already knew but in case someone
missed/skipped the docs it's a healthy reminder. Unless there are different
opinions I proose to go ahead with this one.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2026-08-24 09:38:07 Re: Changing the state of data checksums in a running cluster
Previous Message Amit Kapila 2026-08-24 09:32:15 Re: Proposal: Conflict log history table for Logical Replication