Re: Add explicit warnings about unsafe OAuth trace output for libpq

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Subject: Re: Add explicit warnings about unsafe OAuth trace output for libpq
Date: 2026-08-19 12:06:07
Message-ID: CAN4CZFMPnxX20YtkULfge3moT2agBpEzNvAcS_3A9J8-G6ozqw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Same patches, rebased on current branches.

On Sat, Jun 13, 2026 at 8:34 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Hello
>
> I have re-attached the same patches with simplified commit messages,
> and I also marked the PG18 version with nocfbot so the master version
> can apply correctly.
>
> On Tue, Apr 7, 2026 at 7:28 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> >
> > Hello
> >
> > This is based on earlier messages in the thread about OAUTHDEBUG splitting[1]:
> >
> > >> With the same logic, shouldn't we print a very visible warning when
> > >> somebody enables trace? Since it's a long output, maybe to both the
> > >> beginning and end of the flow?
> > >
> > > I'm more than happy to strengthen this as well, but let's kick that
> > > out to its own thread, especially if pieces are backpatchable.
> >
> > The documentation already mentions that this option is unsafe because
> > it prints out the HTTP traffic as-is, including secrets, but the
> > output itself lacks a warning about it.
> >
> > Because the output is long, users might not notice that copy-pasting
> > it or saving it to disk will share sensitive information. To increase
> > visibility, this patch adds a warning to both the beginning and the
> > end of the output.
> >
> > I also attached a version for 18, since this seems to be a useful
> > change to backport. With the recent changes this is slightly different
> > on 19.
> >
> > [1]: https://www.postgresql.org/message-id/CAOYmi%2Bkfw76zPa-tZPNs4KjxwthGLkQfpGyoKzMMy8_oNJz4DQ%40mail.gmail.com

Attachment Content-Type Size
0001-libpq-oauth-Warn-when-PGOAUTHDEBUG-trace-may-expose-.patch application/octet-stream 1.6 KB
rel18-0001-libpq-oauth-Warn-when-PGOAUTHDEBUG-trace-may-expose-nocfbot.patch application/octet-stream 1.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message torikoshia 2026-08-19 12:14:43 Re: RFC: Allow EXPLAIN to Output Page Fault Information
Previous Message Alexander Korotkov 2026-08-19 11:58:10 Re: MERGE/SPLIT PARTITIONS issues/questions