| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] plpgsql - additional extra checks |
| Date: | 2018-07-03 13:45:55 |
| Message-ID: | 9f715105-45e6-1344-cc3d-71fde27dc248@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/20/2018 01:35 PM, Tomas Vondra wrote:
>
>
> On 03/20/2018 05:36 AM, Pavel Stehule wrote:
>>
>>
>> 2018-03-19 21:47 GMT+01:00 Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com
>> <mailto:tomas(dot)vondra(at)2ndquadrant(dot)com>>:
>>
>> Hi,
>>
>> I'm looking at the updated patch (plpgsql-extra-check-180316.patch), and
>> this time it applies and builds OK. The one thing I noticed is that the
>> documentation still uses the old wording for strict_multi_assignement:
>>
>> WARNING: Number of evaluated fields does not match expected.
>> HINT: strict_multi_assignement check of extra_warnings is active.
>> WARNING: Number of evaluated fields does not match expected.
>> HINT: strict_multi_assignement check of extra_warnings is active.
>>
>> This was reworded to "Number of source and target fields in assignment
>> does not match."
>>
>>
>> fixed
>>
>
> OK, thanks. PFA I've marked it as ready for committer.
>
Stephen, what are your thoughts about this patch? I remember discussing
it with you at pgcon, but I don't recall what exactly your complaints
were. Do you see any problems with the current version of the patch?
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2018-07-03 14:48:15 | Re: SQL/JSON: JSON_TABLE |
| Previous Message | Pavel Stehule | 2018-07-03 12:56:52 | Re: SQL/JSON: functions |