| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: Improve handling of parameter differences in physical replication |
| Date: | 2020-11-30 18:37:36 |
| Message-ID: | 9f2b7b1e-7e41-4258-e86c-2611375ea9af@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-11-20 16:47, Sergei Kornilov wrote:
> Hmm... Good question. How about putting CheckForStandbyTrigger() in a wait loop, but reporting FATAL with an appropriate message, such as "promotion is not possible because of insufficient parameter settings"?
> Also it suits me if we only document that we ignore promote here. I don't think this is an important case. And yes, it's not easy to allow promotion, since we have already updated control file.
>
> Probably we need pause only after we reached consistency?
Here is an updated patch that implements both of these points. I have
used hot standby active instead of reached consistency. I guess
arguments could be made either way, but the original use case really
cared about hot standby.
--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Pause-recovery-for-insufficient-parameter-setting.patch | text/plain | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-11-30 18:42:07 | Re: Add docs stub for recovery.conf |
| Previous Message | David G. Johnston | 2020-11-30 18:31:35 | Re: Add docs stub for recovery.conf |