| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: adding partitioned tables to publications |
| Date: | 2020-03-18 11:16:53 |
| Message-ID: | 9dfea57a-41a6-06d4-ad18-463aeec7ea91@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-03-18 04:06, Amit Langote wrote:
> + if (isnull || !remote_is_publishable)
> + ereport(ERROR,
> + (errmsg("table \"%s.%s\" on the publisher is not publishable",
> + nspname, relname)));
>
> Maybe add a one-line comment above this to say it's an "not supposed
> to happen" error or am I missing something? Wouldn't elog() suffice
> for this?
On second thought, maybe we should just drop this check. The list of
tables that is part of the publication was already filtered by the
publisher, so this query doesn't need to check it again. We just need
the relkind to be able to construct the COPY command, but we don't need
to second-guess it beyond that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-03-18 11:56:19 | Re: [PATCH] Add schema and table names to partition error |
| Previous Message | Julien Rouhaud | 2020-03-18 10:10:55 | Re: Online checksums verification in the backend |