| From: | Jan Wieck <jan(at)wi3ck(dot)info> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dave Cramer <davecramer(at)postgres(dot)rocks>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_upgrade does not upgrade pg_stat_statements properly |
| Date: | 2021-07-30 17:28:32 |
| Message-ID: | 9d3d3311-2191-86f8-86b5-bc765ebd6a19@wi3ck.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/30/21 1:05 PM, Tom Lane wrote:
> I don't see the need for it anyway. What is different from just
> putting the update actions into an extension version upgrade
> script created according to the current rules, and then setting
> that new extension version as the default version in the extension
> build you ship for the new server version?
You are right. The real fix should actually be that an extension, that
creates different objects depending on the major server version it is
installed on, should not use the same version number for itself on those
two server versions. It is actually wrong to have DO blocks that execute
server version dependent sections in the CREATE EXTENSION scripts.
However similar the code may be, it is intended for different server
versions, so it is not the same version of the extension.
Regards, Jan
--
Jan Wieck
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-30 17:58:51 | Re: [PATCH] Hooks at XactCommand level |
| Previous Message | Tom Lane | 2021-07-30 17:05:12 | Re: pg_upgrade does not upgrade pg_stat_statements properly |