| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gilles Darold <gilles(at)darold(dot)net> |
| Cc: | Nicolas CHAHWEKILIAN <leptitstagiaire(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Hooks at XactCommand level |
| Date: | 2021-07-30 17:58:51 |
| Message-ID: | 1112645.1627667931@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Gilles Darold <gilles(at)darold(dot)net> writes:
> [ 00001-startcommand_xact_callback-v2.diff ]
I've not read this version of the patch, but I see from the cfbot's
results that it's broken postgres_fdw. I recall that postgres_fdw
uses the XactCallback and SubXactCallback mechanisms, so I'm betting
this means that you've changed the semantics of those callbacks in
an incompatible way. That's probably not a great idea. We could
fix postgres_fdw, but there are more than likely some external
modules that would also get broken, and that is supposed to be a
reasonably stable API.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-07-30 18:26:50 | Re: logical decoding and replication of sequences |
| Previous Message | Jan Wieck | 2021-07-30 17:28:32 | Re: pg_upgrade does not upgrade pg_stat_statements properly |