Re: coverage additions

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: coverage additions
Date: 2019-06-01 22:37:08
Message-ID: 9cf8a5af29c75895b6daccfa88610824f497d474.camel@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2019-05-30 at 17:54 -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Apparently, for ecpg you have to do "make checktcp" in order for
> > some of
> > the tests to run, and "make check-world" doesn't do that. Not sure
> > what's a good fix for this; do we want to add "make -C
> > src/interfaces/ecpg/test checktcp" to what "make check-world" does,
> > or do we rather what to add checktcp as a dependency of "make
> > check" in
> > src/interfaces/ecpg?
> > Or do we just not want this test to be run by default, and thus I
> > should
> > add "make -C src/interfaces/ecpg/test checktcp" to
> > coverage.pg.org's
> > shell script?
>
> I believe it's intentionally not run by default because it opens up
> an externally-accessible server port.

Correct, iirc.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-06-02 03:07:36 Re: coverage additions
Previous Message Michael Paquier 2019-06-01 19:55:05 Re: Custom table AMs need to include heapam.h because of BulkInsertState