Re: Custom table AMs need to include heapam.h because of BulkInsertState

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Custom table AMs need to include heapam.h because of BulkInsertState
Date: 2019-06-01 19:55:05
Message-ID: 20190601195505.GH1905@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 01, 2019 at 12:19:43PM -0700, Andres Freund wrote:
> Yea, I think we should do that at some point. But I'm not sure this is
> the right design. Bulk insert probably needs to rather be something
> that's allocated inside the AM.

Yeah, actually you may be right that I am not taking the correct path
here. At quick glance it looks that there is a strong relationship
between the finish_bulk_insert callback and the bistate free already,
so we could do much better than moving the code around. Perhaps we
could just have a TODO? As one of the likely-doable items.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2019-06-01 22:37:08 Re: coverage additions
Previous Message Andres Freund 2019-06-01 19:44:05 Re: psql completion bugs with access methods