Re: [PATCH] Introduce array_shuffle() and array_sample()

From: Martin Kalcher <martin(dot)kalcher(at)aboutsource(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()
Date: 2022-09-28 10:40:31
Message-ID: 9cd0925c-9839-a136-c21d-87de9e8a3aa4@aboutsource.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Am 26.09.22 um 22:16 schrieb Tom Lane:
>
> With our current PRNG infrastructure it doesn't cost much to have
> a separate PRNG for every purpose. I don't object to having
> array_shuffle() and array_sample() share one PRNG, but I don't
> think it should go much further than that.
>

Thanks for your thoughts, Tom. I have a couple of questions. Should we
introduce a new seed function for the new PRNG state, used by
array_shuffle() and array_sample()? What would be a good name? Or should
those functions use pg_global_prng_state? Is it safe to assume, that
pg_global_prng_state is seeded?

Martin

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Alvaro Herrera 2022-09-28 11:13:06 Re: is there still a memory leak with hash joins in PG 12.11 ?
Previous Message Lahnov, Igor 2022-09-28 08:50:12 Streaming wal from primiry terminating

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-09-28 10:58:48 Re: SYSTEM_USER reserved word implementation
Previous Message Thomas Munro 2022-09-28 10:35:16 Re: longfin and tamandua aren't too happy but I'm not sure why