Re: ECPG: proposal for new DECLARE STATEMENT

From: David Steele <david(at)pgmasters(dot)net>
To: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ECPG: proposal for new DECLARE STATEMENT
Date: 2020-03-30 16:53:29
Message-ID: 9c7ffec9-8ca3-c393-8e02-74f283439f83@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/11/20 10:41 PM, Tomas Vondra wrote:
> On Sun, Jan 12, 2020 at 03:52:48AM +0100, Tomas Vondra wrote:
>> ...
>>
>> I'm not an ecpg expert (in fact I've never even used it), so my review
>> is pretty superficial, but I only found a couple of minor whitespace
>> issues (adding/removing a line/tab) - see the attached file.
>>
>
> Meh, forgot to attach the file ...

Any thoughts on Tomas' comments?

A big part of moving a patch forward is keeping the thread active and
answering comments/review.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2020-03-30 17:10:19 Re: Add A Glossary
Previous Message Tomas Vondra 2020-03-30 16:51:28 Re: materialization blocks hash join