From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: PXGS vs TAP tests |
Date: | 2021-06-20 14:56:40 |
Message-ID: | 9b21ac1e-c8fd-26bc-32e0-70782076db73@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 6/20/21 10:45 AM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> The recipe for running TAP tests in src/Makefile.global doesn't work for
>> the PGXS case. If you try it you get something like this:
>> ...
>> Notice those bogus settings for top_builddir, PG_REGRESS and
>> REGRESS_SHLIB. The attached patch fixes this bug.
> OK, but does the 'prove_check' macro need similar adjustments?
No, PGXS doesn't support 'make check'. In the case of TAP tests it
really doesn't matter - you're not going to be running against a started
server anyway.
>
>> I removed the REGRESS_SHLIB setting altogether for the PGXS case - it's
>> not clear to me why we need it in a TAP test recipe at all.
> After some digging in the git history, it looks like it's there because
> of Noah's c09850992, which makes me wonder whether 017_shm.pl requires
> it. If so, it'd make more sense perhaps for that one test script
> to set up the environment variable than to have it cluttering every TAP
> run.
Yeah, I'll do some testing.
>
> (In any case, please don't push this till after beta2 is tagged.
> We don't need possible test instability right now.)
>
>
Yes, of course.
cheers
andre
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Herrera | 2021-06-20 16:01:03 | Re: Race condition in InvalidateObsoleteReplicationSlots() |
Previous Message | Tom Lane | 2021-06-20 14:45:21 | Re: PXGS vs TAP tests |