From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Proposed patch for 8.3 VACUUM FULL crash |
Date: | 2008-02-11 21:32:48 |
Message-ID: | 9865.1202765568@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> On investigation the problem occurs because we changed vacuum.c's
>> PageGetFreeSpaceWithFillFactor() to use PageGetHeapFreeSpace()
>> instead of just computing pd_upper - pd_lower as it had done in
>> every previous release. This was *not* a good idea: VACUUM FULL
>> does its own accounting for line pointers and does not need "help".
> Fwiw this change appears to have crept in when the patch was merged.
Yeah, it's entirely likely that this was my fault :-(. It wasn't
apparent at the time that this change wasn't safe and conservative...
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2008-02-12 16:09:38 | Re: tzcode update |
Previous Message | Gregory Stark | 2008-02-11 21:29:15 | Re: Proposed patch for 8.3 VACUUM FULL crash |