Re: Proposed patch for 8.3 VACUUM FULL crash

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> On investigation the problem occurs because we changed vacuum.c's
> PageGetFreeSpaceWithFillFactor() to use PageGetHeapFreeSpace()
> instead of just computing pd_upper - pd_lower as it had done in
> every previous release. This was *not* a good idea: VACUUM FULL
> does its own accounting for line pointers and does not need "help".

Fwiw this change appears to have crept in when the patch was merged.
Ironically while most of us have been complaining about patches not being
widely visible and tested outside of CVS in this case we perhaps suffered from
the opposite problem. The patch was fairly heavily tested on this end before
it was posted and I'm not sure those tests have been repeated since the merge.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's 24x7 Postgres support!