| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | assam258(at)gmail(dot)com, Amit Langote <amitlangote09(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, Ajay Pal <ajay(dot)pal(dot)k(at)gmail(dot)com>, Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SQL Property Graph Queries (SQL/PGQ) |
| Date: | 2026-03-18 07:29:09 |
| Message-ID: | 985a5d4d-1f55-4917-9e06-ef31f53c9ad5@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17.03.26 14:57, Peter Eisentraut wrote:
> On 16.03.26 16:54, Ashutosh Bapat wrote:
>> The patch looks fine to me. While reviewing it, I noticed that the
>> function has an extra loop to count the number of variables. I don't
>> think it's needed. The count can be obtained from the list length. In
>> the attached patch, I have removed that loop. Am I missing something?
>>
>> 0001 is your patch
>> 0002 removes the loop + some cosmetic changes
>
> committed
There are still some pg_upgrade-related failures on the buildfarm, but
AFAICT these are not specifically from this feature but more from the
test design of the PG_TEST_EXTRA="regress_dump_restore" test. It looks
like we need to drop all users at the end of
src/test/regress/sql/graph_table_rls.sql to make this work.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2026-03-18 07:35:47 | Re: Return pg_control from pg_backup_stop(). |
| Previous Message | SATYANARAYANA NARLAPURAM | 2026-03-18 07:28:44 | Re: An attempt to avoid locally-committed-but-not-replicated-to-standby-transactions in synchronous replication |