| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: AIX support - alignment issues |
| Date: | 2022-07-02 21:31:54 |
| Message-ID: | 985075.1656797514@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> What made me look at this issue right now is that the alignment issue lead the
> 56bit relfilenode patch to move the relfilenode field to the start of pg_class
> (ahead of the oid),
Agreed, up with that we should not put. However ...
> because a 64bit value cannot be after a NameData.
... this coding rule strikes me as utterly ridiculous. Why can't we
instead insist that NAMEDATALEN must be a multiple of 8? Anyone who
tries to make it different from that is likely to be wasting padding
space even on platforms where there's not a deeper problem.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-07-02 22:05:54 | Re: O(n) tasks cause lengthy startups and checkpoints |
| Previous Message | Andres Freund | 2022-07-02 20:51:49 | Re: AIX support - alignment issues |