Re: AIX support - alignment issues

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: AIX support - alignment issues
Date: 2022-07-02 20:51:49
Message-ID: 20220702205149.k5qp42n2ztuuhui2@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-07-02 16:34:35 -0400, Tom Lane wrote:
> Agreed. But I think that this sort of thing is better driven by
> "when there's no longer anyone willing to do the legwork" than
> by project policy. IOW, we'll stop when Noah gets tired of doing
> it (and no one steps up to take his place).

I do think we should take the impact it has on everyone into account, not just
Noah's willingness. If it's just "does somebody still kind of maintain it"
then we'll bear the distributed cost of complications for irrelevant platforms
way longer than worthwhile.

> In the case at hand, given that the test added by 79b716cfb/c1da0acbb
> correctly detects troublesome catalog layouts (and no I've not studied
> it myself), I don't see that we have to do more right now.

What made me look at this issue right now is that the alignment issue lead the
56bit relfilenode patch to move the relfilenode field to the start of pg_class
(ahead of the oid), because a 64bit value cannot be after a NameData. Now, I
think we can do a bit better by moving a few more fields around. But the
restriction still seems quite onerous.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-02 21:31:54 Re: AIX support - alignment issues
Previous Message Tom Lane 2022-07-02 20:34:35 Re: AIX support - alignment issues