Re: BUG #5016: dlltool error in libecpg_compatdll.def

On Thu, Aug 27, 2009 at 19:41, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> 2009/8/27 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> Fix applied - exports.txt had a tab in it, instead of spaces, to
>>>> separate the field from the number.
>>>
>>> Hmm, maybe it would be better to fix whatever sed script is presuming
>>> the form of the whitespace?  Because otherwise we'll surely get bitten
>>> again.
>
>> Well, we havent' been bitten by the requirement for years in libpq,
>> but I guess that's a point.
>
>> Given my comfort-level for
>> sed-embedded-in-makefile-escaping-requirements, I'll be happy to see
>> someone else do it, given that it'd likely take me 100 tries to get it
>> right :D
>
> I'll fix the Makefiles if you'll fix whatever is the equivalent part of
> the MSVC perl scripts ...

Thanks.

MSVC already gets it right. It uses the perl split() function, which
accepts both spaces and tabs.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/