| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] "could not reattach to shared memory" on Windows |
| Date: | 2009-07-24 20:13:17 |
| Message-ID: | 9837222c0907241313w2d15e86fj38dc5e928b01e6@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 23, 2009 at 09:04, Magnus Hagander<magnus(at)hagander(dot)net> wrote:
> On Thu, Jul 23, 2009 at 08:04, Tsutomu Yamada<tsutomu(at)sraoss(dot)co(dot)jp> wrote:
>> Hello,
>>
>> Thank you for correcting patch.
>> However, I think the following block have to use VirualFree*Ex*().
>>
>> (yes, this should never happen, maybe there is actually no problem.
>> but for logical correctness)
>
> That is definitely correct. I have updated the patch in my tree and
> will make sure to include that in the eventual commit.
>
> FYI, and others, I have received a couple of off-list reports from
> people testing out the patch, and so far only positive results.
I have applied this patch to HEAD so we can get buildfarm coverage.
Holding back on the batckpatch for a bit longer.
--
Magnus Hagander
Self: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2009-07-24 20:24:28 | Re: Proposal: More portable way to support 64bit platforms |
| Previous Message | Magnus Hagander | 2009-07-24 20:12:42 | pgsql: Reserve the shared memory region during backend startup on |