Re: [PATCH] Remove unused include from analyze.c

> On 23 Jul 2026, at 04:23, Quan Zongliang <quanzongliang(at)yeah(dot)net> wrote:
> On 7/5/26 9:27 PM, Dongpo Liu wrote:

>> The attached patch removes it. The file compiles cleanly without it,
>> and I verified that no other symbol from procarray.h is referenced there.
> Agree.
>
> Furthermore, I also discovered that there are other files that contain this unnecessary references. Please take a look at the new patch in the attachment.

This version doesn't seem to work.

../contrib/amcheck/verify_heapam.c:773:5: error: call to undeclared function 'TransactionIdIsInProgress'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
TransactionIdIsInProgress(curr_xmin))
^
../contrib/amcheck/verify_heapam.c:2168:12: error: call to undeclared function 'TransactionIdIsInProgress'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
else if (TransactionIdIsInProgress(xid))
^
2 errors generated.

--
Daniel Gustafsson