Re: [PATCH] Remove unused include from analyze.c

On 7/5/26 9:27 PM, Dongpo Liu wrote:
> Hi hackers,
>
> While reading the ANALYZE code, I noticed that
> src/backend/commands/analyze.c still includes storage/procarray.h,
> but nothing in the file uses it anymore.
>
> Commit 284925508ae removed the call to
> GetOldestNonRemovableTransactionId() from acquire_sample_rows(), which
> was the last reference to anything declared in that header. The #include
> was left behind.
>
> The attached patch removes it. The file compiles cleanly without it,
> and I verified that no other symbol from procarray.h is referenced there.
>
Agree.

Furthermore, I also discovered that there are other files that contain
this unnecessary references. Please take a look at the new patch in the
attachment.

--
Quan Zongliang