Re: ICU for global collation

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Daniel Verite <daniel(at)manitou-mail(dot)org>
Subject: Re: ICU for global collation
Date: 2022-06-27 07:10:29
Message-ID: 97f2c29e-24d9-3660-60cf-9138c0c47d90@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27.06.22 08:42, Michael Paquier wrote:
> On Mon, Jun 27, 2022 at 08:23:59AM +0200, Peter Eisentraut wrote:
>> On 26.06.22 05:51, Julien Rouhaud wrote:
>>> On Sat, Jun 25, 2022 at 10:19:30AM -0500, Justin Pryzby wrote:
>>>>> + if (GET_MAJOR_VERSION(old_cluster.major_version) <= 1500)
>>
>> I think the fix here is to change <= to < ?
>
> Yes.

Ok, committed.

(I see now that in the context of pg_upgrade, writing <= 1400 is
equivalent, but I find that confusing, so I did < 1500.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hamid Akhtar 2022-06-27 07:31:55 Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row
Previous Message Noah Misch 2022-06-27 07:04:57 Re: last_archived_wal is not necessary the latest WAL file (was Re: pgsql: Add test case for an archive recovery corner case.)