| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Subject: | Re: ICU for global collation |
| Date: | 2022-06-28 01:32:05 |
| Message-ID: | 20220628013205.GH19662@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 27, 2022 at 09:10:29AM +0200, Peter Eisentraut wrote:
> On 27.06.22 08:42, Michael Paquier wrote:
> > On Mon, Jun 27, 2022 at 08:23:59AM +0200, Peter Eisentraut wrote:
> > > On 26.06.22 05:51, Julien Rouhaud wrote:
> > > > On Sat, Jun 25, 2022 at 10:19:30AM -0500, Justin Pryzby wrote:
> > > > > > + if (GET_MAJOR_VERSION(old_cluster.major_version) <= 1500)
> > >
> > > I think the fix here is to change <= to < ?
> >
> > Yes.
>
> Ok, committed.
>
> (I see now that in the context of pg_upgrade, writing <= 1400 is equivalent,
> but I find that confusing, so I did < 1500.)
I suggested using <= 1400 for consistency with the other code, and per
bc1fbc960. But YMMV.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-06-28 01:58:49 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Michael Paquier | 2022-06-28 01:12:48 | Repeatability of installcheck for test_oat_hooks |