| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: unused/redundant foreign key code |
| Date: | 2018-11-10 15:23:38 |
| Message-ID: | 9728f6f6-7b95-6107-42cc-cf6ec2c91228@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/11/2018 21:37, Daniel Gustafsson wrote:
>> On 8 Aug 2018, at 21:34, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>
>> I found some unused and some redundant code in ri_triggers.c that was
>> left around by some previous changes that aimed to optimize away certain
>> trigger invocations. See attached patches.
>
> Both of these patches apply cleanly with minimal offsets, build without
> warnings and make check passes.
>
> From reading code and testing, I concur with your findings that this is indeed
> dead code.
>
> +1 on this cleanup, I’m marking this as Ready for Committer.
Committed, thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vik Fearing | 2018-11-10 18:12:54 | Re: proposal: variadic argument support for least, greatest function |
| Previous Message | Daniel Westermann | 2018-11-10 15:21:06 | Re: zheap: a new storage format for PostgreSQL |