Re: unused/redundant foreign key code

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unused/redundant foreign key code
Date: 2018-11-09 20:37:08
Message-ID: 322A3C3B-C336-4A26-BC5F-A1CD70192B1C@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 8 Aug 2018, at 21:34, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> I found some unused and some redundant code in ri_triggers.c that was
> left around by some previous changes that aimed to optimize away certain
> trigger invocations. See attached patches.

Both of these patches apply cleanly with minimal offsets, build without
warnings and make check passes.

From reading code and testing, I concur with your findings that this is indeed
dead code.

+1 on this cleanup, I’m marking this as Ready for Committer.

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jürgen Strobel 2018-11-09 21:03:12 Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Previous Message Pavel Stehule 2018-11-09 19:37:10 Re: repeated procedure call error