| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: automating perl compile time checking |
| Date: | 2018-06-15 11:06:50 |
| Message-ID: | 96df1a9b-9023-6c1f-9650-c4425c120132@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/15/2018 12:21 AM, Peter Eisentraut wrote:
> On 6/11/18 16:06, Andrew Dunstan wrote:
>> This affects pretty much nothing. In fact some of the other changes I've
>> recently committed were arguably more dangerous. Do you want me to
>> revert the whole lot?
> No, but this whole let's clean up the Perl code initiative seemed to
> have come out of nowhere after feature freeze. The Perl code was fine
> before, so if we're going to be polishing it around it should go into
> the next release. I would actually have liked to have had more time to
> discuss some of the changes, since I didn't seem to agree to some of
> them at first reading.
>
There were changes made for perlcritic, but almost none for this check.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2018-06-15 11:10:04 | Re: Jsonb transform for pl/python |
| Previous Message | Amit Langote | 2018-06-15 09:30:25 | Re: why partition pruning doesn't work? |