Re: [PATCH] Two remaining shmem attachment issues in single-user mode

> On Sep 23, 2026, at 02:52, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Sun, Sep 20, 2026 at 1:28 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> Also, for v1-0001, I personally don't feel that the new test is really necessary. This doesn't seem like particularly fragile logic that's likely to regress accidentally,
>
> (But the claim being made is that it _did_ regress accidentally, right?)
>
>> and I've noticed that Tom generally seems reluctant to increase test runtime, even by a very small amount, unless the test provides clear value.
>
> I haven't reviewed the whole patch, but as someone who'd really prefer
> that every bug fix be accompanied by a regression test if possible, I
> don't think we should be discouraging people from writing them. Don't
> waste resources, sure, but don't avoid writing tests. A committer can
> always strip an overly-expensive test out before committing.
>

That’s a good point. Noted.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/