| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Two remaining shmem attachment issues in single-user mode |
| Date: | 2026-09-22 18:52:07 |
| Message-ID: | CAOYmi+mgocNqp2SjBmQ3FLTsJg=C+b_zprH4B5L7HdJJ-0h3hw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 20, 2026 at 1:28 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> Also, for v1-0001, I personally don't feel that the new test is really necessary. This doesn't seem like particularly fragile logic that's likely to regress accidentally,
(But the claim being made is that it _did_ regress accidentally, right?)
> and I've noticed that Tom generally seems reluctant to increase test runtime, even by a very small amount, unless the test provides clear value.
I haven't reviewed the whole patch, but as someone who'd really prefer
that every bug fix be accompanied by a regression test if possible, I
don't think we should be discouraging people from writing them. Don't
waste resources, sure, but don't avoid writing tests. A committer can
always strip an overly-expensive test out before committing.
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Manu | 2026-09-22 18:56:10 | Re: Fix race condition in SSI when reading PredXact->SxactGlobalXmin |
| Previous Message | Lukas Fittl | 2026-09-22 18:49:05 | Re: PostgreSQL 19 Beta 4 release announcement draft |