From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: Time based lag tracking for logical replication |
Date: | 2017-04-29 18:52:05 |
Message-ID: | 962f2762-a8c6-9f99-9962-610f4be2f099@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 23/04/17 01:10, Petr Jelinek wrote:
> Hi,
>
> The time based lag tracking commit [1] added interface for logging
> progress of replication so that we can report lag as time interval
> instead of just bytes. But the patch didn't contain patch for the
> builtin logical replication.
>
> So I wrote something that implements this. I didn't like all that much
> the API layering in terms of exporting the walsender's LagTrackerWrite()
> for use by plugin directly. Normally output plugin does not have to care
> if it's running under walsender or not, it uses abstracted write
> interface for that which can be implemented in various ways (that's how
> we implement SQL interface to logical decoding after all). So I decided
> to add another function to the logical decoding write api called
> update_progress and call that one from the output plugin. The walsender
> then implements that new API to call the LagTrackerWrite() while the SQL
> interface just does not implement it at all. This seems like cleaner way
> of doing it.
>
The original no longer applies after Andres committed some of my fixes
for snapshot builder so here is rebased version.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
Add-support-for-time-based-lag-tracking-to-logical-170429.patch | binary/octet-stream | 12.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2017-04-29 21:42:01 | Re: snapbuild woes |
Previous Message | Noah Misch | 2017-04-29 18:18:45 | Re: Re: logical replication and PANIC during shutdown checkpoint in publisher |